[openib-general] Please don't commit without maintainer approval

Roland Dreier rdreier at cisco.com
Sun Apr 9 21:48:46 PDT 2006


    Robert> FWIW, sysfsutils-devel doesn't exist on SuSE: the header
    Robert> files are in sysfsutils instead.  That's probably why
    Robert> Bryan made that change: he picked it up from a change
    Robert> (never submitted) I'd made many months ago.  I don't think
    Robert> this would be a big deal for yum, since it's a
    Robert> BuildRequires, not a Requires.  It certainly hasn't been
    Robert> an issue for us at PathScale, and we've been using it for
    Robert> ages.

It was actually both BuildRequires and Requires.  But yum is smarter
than I gave it credit for -- it does work to depend on libsysfs.h.  So
I checked in the change below.

However, committing this without telling anyone was still the wrong
way to handle this, and the rest of the changes were either wrong or
didn't matter either way.

 - R.

--- src/userspace/libibverbs/libibverbs.spec.in	(revision 6351)
+++ src/userspace/libibverbs/libibverbs.spec.in	(working copy)
@@ -13,7 +13,7 @@ Url: http://openib.org/
 Source: http://openib.org/downloads/libibverbs-1.0.3.tar.gz
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
-BuildRequires: sysfsutils-devel
+BuildRequires: %{_includedir}/sysfs/libsysfs.h
 
 %description
 libibverbs is a library that allows userspace processes to use
@@ -27,7 +27,7 @@ also be installed.
 %package devel
 Summary: Development files for the libibverbs library
 Group: System Environment/Libraries
-Requires: %{name} = %{version}-%{release} sysfsutils-devel
+Requires: %{name} = %{version}-%{release} %{_includedir}/sysfs/libsysfs.h
 
 %description devel
 Static libraries and header files for the libibverbs verbs library.



More information about the general mailing list