[openib-general] Re: [PATCH] git: updates to rdma_cm branch

[Roland Dreier]

OK, I updated my rdma_cm branch with all of this.

In addition I put the following in -- it's idiomatic in the kernel to
let the compiler handle htons(A_CONSTANT) in code.  Should I commit
this to svn too?

diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index 810fdd5..d294bbc 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -333,8 +333,8 @@ static int addr_arp_recv(struct sk_buff 
 
 	arp_hdr = (struct arphdr *) skb->nh.raw;
 
-	if (arp_hdr->ar_op == __constant_htons(ARPOP_REQUEST) ||
-	    arp_hdr->ar_op == __constant_htons(ARPOP_REPLY))
+	if (arp_hdr->ar_op == htons(ARPOP_REQUEST) ||
+	    arp_hdr->ar_op == htons(ARPOP_REPLY))
 		set_timeout(jiffies);
 
 	kfree_skb(skb);