[openib-general][patch review] srp: fmr implementation,

Vu Pham vuhuong at mellanox.com
Tue Apr 18 10:09:06 PDT 2006


Roland Dreier wrote:
>  > The return happened before reaching the code above. It happened at:
>  > 	if (!wait_for_completion_timeout(&req->done,
>  > 					 msecs_to_jiffies(SRP_ABORT_TIMEOUT_MS)))
>  > 		return FAILED;
>  > 
>  > because the qp was in fatal state. Therefore, the command was not
>  > finished or removed from the pending queue
> 
> Hmm... we're returning FAILED from the abort handler.  That means the
> SCSI midlayer should not free the associated SCSI command yet, right?
> 

Right for abort command; however, I'm not sure after scsi 
midlayer called device_reset

With some extra printk statement inserted in I don't see the
crash anymore. Debug printk probably change the timing

Vu



More information about the general mailing list