[openib-general] RE: SDP hello ack header

Sean Hefty sean.hefty at intel.com
Thu Apr 27 09:22:20 PDT 2006


>I don't care much. It seems to make sense for CMA to set it.

I created a patch for this.  The easiest fix was to set the version in the
private_data passed to the CMA by SDP; however, the private_data is declared as
const void *.

This made me stop and think about the problem more.  Both the CMA and SDP must
agree on which version of the headers are used.  If the CMA sets the version,
then there's no way for SDP to use anything different, or to know which version
will be used by the CMA.  This makes will make it difficult or impossible for
SDP to support multiple versions.

I think that a better solution is to have SDP set the version information for
all headers.  The CMA can then check the version to see if it can support it,
and set the other fields appropriately.  Thoughts?

- Sean



More information about the general mailing list