[openib-general] Fwd: issues in ipoib

[Sean Hefty]

> static void ib_sa_path_rec_callback(struct ib_sa_query *sa_query,
> 				    int status,
> 				    struct ib_sa_mad *mad)
>@@ -539,6 +551,7 @@ static void ib_sa_path_rec_callback(stru
> 	struct ib_sa_path_query *query =
> 		container_of(sa_query, struct ib_sa_path_query, sa_query);
>
>+	ib_sa_client_get(sa_query->client);

It makes more sense to me to increment the reference count when the query is
initiated.  We don't know that sa_query->client is still valid here unless a
reference was taken earlier.

I like this approach, but would like to see it expanded to track the requests,
to avoid duplicating this work in every client.  Unregistration would then
cancel all outstanding queries issued by the user.

- Sean