[openib-general] [PATCH] sa_query: require SA query registration

[Michael S. Tsirkin]

Quoting r. Sean Hefty <sean.hefty at intel.com>:
> @@ -1202,6 +1213,7 @@ err_fs:
>  
>  static void __exit ipoib_cleanup_module(void)
>  {
> +	ib_sa_unregister_client(ipoib_sa_client);
>  	ib_unregister_client(&ipoib_client);
>  	ipoib_unregister_debugfs();
>  	destroy_workqueue(ipoib_workqueue);

I think you must call ib_unregister_client first, before
ib_sa_unregister_client. This is because ib_unregister_client
triggers hotplug event which cancels all queries.

If you don't do this, you'll get a deadlock as ipoib
might retry the queries forever.

Same probably applies to other modules.

-- 
MST