[openib-general] [PATCH] sa_query: require SA query registration

Michael S. Tsirkin mst at mellanox.co.il
Mon Aug 7 16:59:07 PDT 2006


Quoting r. Sean Hefty <sean.hefty at intel.com>:
> >Further, why should this API be different from ib_register_client?
> >Isn't this confusing?
> 
> It's different from ib_register_client, but more similar to
> ib_register_mad_agent.  If anything it would make more sense to be closer to
> ib_register_mad_agent.

Actually, different from both - we don't get events in the sa_client.
We just need a cookie to track queries to synchronise for module unloading.
Maybe rename to ib_sa_query_cookie or something?

> For example, a callback function makes more sense passed
> into a register call than every query call.

So ULPs will need multiple clients for multiple types of queries? Ugh.

-- 
MST




More information about the general mailing list