[openib-general] [PATCH 1/7] IB/ipath - performance improvements via mmap of queues

Or Gerlitz ogerlitz at voltaire.com
Mon Aug 14 01:00:33 PDT 2006


>> I find it somehow hard to review your patch set as of two
>> reasons: (a) all the patches having the same subject line 

> a) I thought using the same subject line was the convention since
>    it is essentially one patch.  I split it due to size and the
>    fact that each patch has a different owner.

Nope, the convention is to have the subject line telling what it this 
patch role within the patch series very similarly to what you have 
stated in some beginning of most of the patches. Another useful practice 
is to have all the patches sent over the same thread.

> The bulk of the changes are to the InfiniPath kernel driver (ib_ipath)
> to support mmap'ing the CQ and receive queues (QP, SRQ) into
> the user level verbs library.

> The changes to the core IB were neccessary in order to allow
> additional information (i.e., the mmap offset) to be returned
> from the kernel driver to the user level verbs driver plugin.

thanks for the clarification.

Or.






More information about the general mailing list