[openib-general] [PATCH] mthca: make IB_SEND_FENCE work

Michael S. Tsirkin mst at mellanox.co.il
Mon Aug 14 14:08:05 PDT 2006


Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [PATCH] mthca: make IB_SEND_FENCE work
> 
> Michael S. Tsirkin wrote:
> > We still need to test size0 to set size0 = size.
> > So we just reuse the extra branch, and I agree with Roland
> > this way code is clearer.
> 
> You're right; I missed where size0 was used below the loop.
> 
> Then I think we can also do without initializing op0 = 0, and we can eliminate 
> the size0 initialization by changing if (!size0) to if (!nreq).
> 
> - Sean
> 

There's the ee_nds line above that tests size0 and should be changed
then as well.

-- 
MST




More information about the general mailing list