[openib-general] [PATCH] IB/core: fix SM LID/LID change withclient reregister set

Hal Rosenstock halr at voltaire.com
Tue Aug 15 10:22:01 PDT 2006


On Tue, 2006-08-15 at 12:45, Michael S. Tsirkin wrote:
> Quoting r. Hal Rosenstock <halr at voltaire.com>:
> > > This patch simply restores the previous behavior of the sa_query and cache 
> > > modules in responding to events.
> > 
> > Understood but doesn't it also has the effect of doing more than this
> > for certain cases of Set PortInfo ?
> 
> Not that I can see.

It's more based on what the driver(s) is/are doing which is not your
change but is the one (back on May 31) which caused this change to be
needed. Client reregister takes precedence over LID change so client
reregister needs to do everything LID change does and possibly more.

Your change looks fine to me. 

What about local_sa ? Does it need this change too ?

-- Hal

> > > No reregistration is required in these modules.
> > 
> > Currently but I think it is a possibility in the future.
> 
> So then we'll have to do it.





More information about the general mailing list