[openib-general] [PATCH 5/5] opensm: updates file and up/downrouting engines

Hal Rosenstock halr at voltaire.com
Wed Dec 6 10:14:10 PST 2006


Hi Eitan,

On Wed, 2006-12-06 at 12:42, Eitan Zahavi wrote:
> Hi Hal,
> 
> Hal Rosenstock wrote:
> > Hi Eitan,
> >
> > On Wed, 2006-12-06 at 08:25, Eitan Zahavi wrote:
> >   
> >> Hi Hal,
> >>
> >> I just run one iteration of the simulation regression against the git tree:
> >> The Multicast fails on the change of format of osm.mcfdbs
> >>     
> >
> > Is this change in OFED 1.1 too ? If so, can the validation be enhanced
> > to handle the empty MLID case ? 
> >   
> The current format (broken) where multiple MLIDs apear on one line is 
> harder to manage.

Is it true for OFED 1.1 as well ?

Also, I'm in the process of incorporating your change.

> I will also need to change ibutils to generate the new format.Whenever 
> such a format change
> I have to chase it through whatever utility is out there that breaks.
> I do not see any reason why it had to change. I understand it was broken 
> by the fix that eliminate the need for
> opening the file and appending to it.

I'm not sure it was done by design or accident. Anyhow, the patches were
out on the list for quite some time without comment.

> Instead of modifying ibutils and the simulator tests I propose to fix it 
> back to what it was
> using the patch I provided.

I'm in the process of incorporating your patch.

-- Hal

> >> The Stability flows failed on the change of subnet.lst to osm-subnet.lst ...
> >>     
> >
> > Yes, this patch went out on the list on 11/29 and committed on 11/30.
> > We had agreed this would be done after SC. Can the verification be
> > changed to look for this file so this doesn't fail ?
> >   
> Yes this is a simple fix and it was already pushed into ibutils. I 
> missed the simulator tests and pushed the change today.
> > It also indicated that a similar change is needed to ibutils
> > Has that been done ?
> >   
> Yes ibutils modified to accommodate for this change.
> > -- Hal
> >
> >   
> >> doing another loop: run=0 cron=0 hour=14
> >> OsmStress IS1-16.topo ... PASS
> >> LidMgr IS1-16.topo ... PASS
> >> LidMgr IS1-16.topo ... PASS
> >> LidMgr IS1-16.topo ... PASS
> >> LidMgr IS3-128.topo ... PASS
> >> Multicast IS1-16.topo ... FAIL (sleeping 10)
> >> Multicast IS1-16.topo ... FAIL (sleeping 10)
> >> Multicast IS1-16.topo ... FAIL (sleeping 10)
> >> Multicast IS3-128.topo ... FAIL (sleeping 10)
> >> Multicast IS3-loop.topo ... FAIL (sleeping 10)
> >> Stability IS1-16.topo ... FAIL (sleeping 10)
> >> Stability IS1-16.topo ... FAIL (sleeping 10)
> >> Stability IS1-16.topo ... FAIL (sleeping 10)
> >> Stability IS3-128.topo ... FAIL (sleeping 10)
> >> Stability IS3-loop.topo ... FAIL (sleeping 10)
> >> OsmTest IS1-16.topo ... PASS
> >> OsmTest IS1-16.topo ... PASS
> >> OsmTest IS1-16.topo ... PASS
> >> OsmTest IS3-128.topo ... PASS
> >> OsmTest IS3-loop.topo ... PASS
> >> Pkey IS1-16.topo ... PASS
> >> Pkey IS1-16.topo ... PASS
> >> Pkey IS1-16.topo ... PASS
> >> Pkey IS3-128.topo ... PASS
> >> OsmStress IS1-16.topo ... PASS
> >> OsmStress IS1-16.topo ... PASS
> >> OsmStress IS3-128.topo ... PASS
> >>
> >>
> >> Eitan Zahavi wrote:
> >>     
> >>> Run against SVN.
> >>> Will move to GIT today (hopefully  - if I am able to git clone without
> >>> password ...)
> >>>
> >>> Eitan Zahavi
> >>> Senior Engineering Director, Software Architect
> >>> Mellanox Technologies LTD
> >>> Tel:+972-4-9097208
> >>> Fax:+972-4-9593245
> >>> P.O. Box 586 Yokneam 20692 ISRAEL
> >>>
> >>>
> >>>   
> >>>       
> >>>> -----Original Message-----
> >>>> From: Hal Rosenstock [mailto:halr at voltaire.com]
> >>>> Sent: Wednesday, December 06, 2006 1:12 PM
> >>>> To: Eitan Zahavi
> >>>> Cc: openib-general at openib.org
> >>>> Subject: Re: [openib-general] [PATCH 5/5] opensm: updates file and
> >>>> up/downrouting engines
> >>>>
> >>>> On Wed, 2006-12-06 at 05:39, Eitan Zahavi wrote:
> >>>>     
> >>>>         
> >>>>> Eitan Zahavi wrote:
> >>>>>       
> >>>>>           
> >>>>>> Hal Rosenstock wrote:
> >>>>>>
> >>>>>>         
> >>>>>>             
> >>>>>>> On Sun, 2006-11-26 at 17:30, Sasha Khapyorsky wrote:
> >>>>>>>
> >>>>>>>
> >>>>>>>           
> >>>>>>>               
> >>>>>>>> This updates "file" and "updn" (up/down) routing engines which
> >>>>>>>> should work properly now with changed LFT setup mechanism.
> >>>>>>>>
> >>>>>>>> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>             
> >>>>>>>>                 
> >>>>>>> Thanks. Applied.
> >>>>>>>
> >>>>>>>
> >>>>>>>           
> >>>>>>>               
> >>>>>> Are these patches inserted into SVN or GIT
> >>>>>>
> >>>>>>         
> >>>>>>             
> >>>>> Ignore this - just cloned GIT and its there
> >>>>>       
> >>>>>           
> >>>> Were your latest regressions run against svn or git clone ?
> >>>>
> >>>> -- Hal
> >>>>
> >>>>     
> >>>>         
> >>>>>> Eitan
> >>>>>>
> >>>>>>         
> >>>>>>             
> >>>>>>> -- Hal
> >>>>>>>
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> openib-general mailing list
> >>>>>>> openib-general at openib.org
> >>>>>>> http://openib.org/mailman/listinfo/openib-general
> >>>>>>>
> >>>>>>> To unsubscribe, please visit
> >>>>>>> http://openib.org/mailman/listinfo/openib-general
> >>>>>>>
> >>>>>>>
> >>>>>>>           
> >>>>>>>               
> >>>>>> _______________________________________________
> >>>>>> openib-general mailing list
> >>>>>> openib-general at openib.org
> >>>>>> http://openib.org/mailman/listinfo/openib-general
> >>>>>>
> >>>>>> To unsubscribe, please visit
> >>>>>> http://openib.org/mailman/listinfo/openib-general
> >>>>>>
> >>>>>>         
> >>>>>>             
> >>> _______________________________________________
> >>> openib-general mailing list
> >>> openib-general at openib.org
> >>> http://openib.org/mailman/listinfo/openib-general
> >>>
> >>> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> >>>   
> >>>       
> >
> >
> > _______________________________________________
> > openib-general mailing list
> > openib-general at openib.org
> > http://openib.org/mailman/listinfo/openib-general
> >
> > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> >   
> 





More information about the general mailing list