[openib-general] [PATCH][TRIVIAL] OpenSM/osm_ucast_updn.c: In updn_init, add routine exit osm_log message for an error case

Hal Rosenstock halr at voltaire.com
Wed Dec 6 14:46:14 PST 2006


OpenSM/osm_ucast_updn.c: In updn_init, add routine exit osm_log message
for an error case

Also, some cosmetic changes

Signed-off-by: Hal Rosenstock <halr at voltaire.com>

diff --git a/osm/opensm/osm_ucast_updn.c b/osm/opensm/osm_ucast_updn.c
index 7e6a6d5..b0ea721 100644
--- a/osm/opensm/osm_ucast_updn.c
+++ b/osm/opensm/osm_ucast_updn.c
@@ -33,7 +33,6 @@
  *
  */
 
-
 /*
  * Abstract:
  *      Implementation of Up Down Algorithm using ranking & Min Hop
@@ -272,7 +271,7 @@ __updn_bfs_by_node(
              "__updn_bfs_by_node:"
              "Update Min Hop Table of GUID 0x%" PRIx64 "\n",
              cl_ntoh64(p_port->guid) );
-    osm_switch_set_hops(p_self_node, root_lid , 0, 0);
+    osm_switch_set_hops(p_self_node, root_lid, 0, 0);
   }
   else
   {
@@ -598,7 +597,7 @@ updn_init(
   if (!p_list)
   {
     status = IB_ERROR;
-    goto Exit_Bad;
+    goto Exit;
   }
 
   cl_list_construct( p_list );
@@ -630,7 +629,7 @@ updn_init(
     {
       if (strcspn(line, " ,;.") == strlen(line))
       {
-        /* Skip empty Lines anywhere in the file - only one char means the Null termination */
+        /* Skip empty lines anywhere in the file - only one char means the Null termination */
         if (strlen(line) > 1)
         {
           p_tmp = malloc(sizeof(uint64_t));
@@ -670,12 +669,8 @@ updn_init(
   }
   /* If auto mode detection required - will be executed in main b4 the assignment of UI Ucast */
 
-  goto Exit;
-
-  Exit_Bad :
-    return 1;
-  Exit :
-    OSM_LOG_EXIT( &p_osm->log );
+Exit :
+  OSM_LOG_EXIT( &p_osm->log );
   return (status);
 }
 







More information about the general mailing list