[openib-general] Re: [PATCH] Opensm - using default dir

[Hal Rosenstock]

On Thu, 2006-02-02 at 08:31, Sasha Khapyorsky wrote:
> On 18:13 Wed 01 Feb     , Hal Rosenstock wrote:
> > On Wed, 2006-02-01 at 17:59, Sasha Khapyorsky wrote:
> > > On 14:41 Mon 30 Jan     , Michael S. Tsirkin wrote:
> > > > Quoting r. Yael Kalka <yael at mellanox.co.il>:
> > > > > ===================================================================
> > > > > --- include/opensm/osm_svn_revision.h	(revision 5203)
> > > > > +++ include/opensm/osm_svn_revision.h	(working copy)
> > > > > @@ -1 +1 @@
> > > > > -#define OSM_SVN_REVISION ""
> > > > > +#define OSM_SVN_REVISION "5203M"
> > > > 
> > > > This looks like a mistake.
> > > > And, I think this shows that keeping the generated file osm_svn_revision.h
> > > > represents a problem.
> > > 
> > > Good point. Hal, could we svn-remove this file?
> > 
> > Yes, this is possible but there is a little more work involved here as
> > the OSM_SVN_REVISION is checked for length 0 to determine whether to
> > print out the svn version message right now.
> 
> It is ok. What I mean (and believe Michael too) is to not store
> osm_svn_revision.h under SVN, but generate in build time. Like this:

Got it. Thanks. Applied.

-- Hal