[openib-general] Pathscale driver build broken in SVN5330

Robert Walsh rjwalsh at pathscale.com
Tue Feb 7 18:30:03 PST 2006


On Tue, 2006-02-07 at 09:29 -0800, Roland Dreier wrote:
> Thanks, I broke this when I merged Or's FMR patch.
> I checked in this fix:
> 
> --- infiniband/hw/ipath/ipath_verbs.c	(revision 5330)
> +++ infiniband/hw/ipath/ipath_verbs.c	(working copy)
> @@ -5756,7 +5756,7 @@ static struct ib_fmr *ipath_alloc_fmr(st
>  	fmr->mr.offset = 0;
>  	fmr->mr.access_flags = mr_access_flags;
>  	fmr->mr.max_segs = fmr_attr->max_pages;
> -	fmr->page_size = fmr_attr->page_size;
> +	fmr->page_size = fmr_attr->page_shift;
>  	return &fmr->ibfmr;
>  }

Thanks, Roland.  I followed up with a fix to change our private struct
member to page_shift, too, just to be consistent.

BTW: we should have a new driver drop shortly.  This won't be one
suitable for submission to the kernel, but it will match our newly
shipped InfiniPath software (1.2, which went live today.)  We're still
working on incorporating all the feedback from lkml.

Regards,
 Robert.

-- 
Robert Walsh                                 Email: rjwalsh at pathscale.com
PathScale, Inc.                              Phone: +1 650 934 8117
2071 Stierlin Court, Suite 200                 Fax: +1 650 428 1969
Mountain View, CA 94043.





More information about the general mailing list