[openib-general] Re: [PATCH] add asm-generic/mman.h

[Michael S. Tsirkin]

Quoting r. Linus Torvalds <torvalds at osdl.org>:
> Rule #1: use tools instead of eyeballs whenever you possibly can. Humans 
> are bad at noticing changes like this.

OK, this

#!/usr/bin/perl

my %new_values;
my @old_names;
my @old_values;
while (<>)
{
	if (m/^\+#define\s+(\S+)\s+(\S+)\s+.*$/) {
		$new_values{$1}=$2;
	}
	if (m/^\-#define\s+(\S+)\s+(\S+)\s+.*$/) {
		push @old_names, $1;
		push @old_values, $2;
	}
}

for (my $i = 0; $i <= $#old_values; $i++) {
	if (oct($new_values{$old_names[$i]}) != oct($old_values[$i])) {
		print "Changed: $old_names[$i] $old_values[$i] " .
		      " to $new_values{$old_names[$i]}\n";
	}
}

Shows that the only numbers changed are
MADV_REMOVE
MADV_DONTFORK
MADV_DOFORK

As was intended.
OK now?

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies