[openib-general] Re: Re: [PATCH RESEND] net: Move destructor from neigh->ops to neigh_params

[Michael S. Tsirkin]

Quoting r. Shirley Ma <xma at us.ibm.com>:
> Subject: Re: Re: [PATCH RESEND] net: Move destructor from?neigh->ops to neigh_params
> 
> 
> Michael,
> 
> > With this approach you'll get crashes when the module will get unloaded.
> I haven't hit the crash yet when unloading the module. Could you explain it in detail?
> 
> Do you mean, it might hit below problem?
>         unregister_netdevice: waiting for ib0 to become free. Usage count = 3

I think one of the patches might fix this.

> > Further, we may get called with neighbour that is not related to ipoib at all.
> The none ipoib related neighbour shouldn't have an ipoib destructor allocated.

the destructor isnt per neighbour, unfortunately.
Thats what my kernel patches fix.

> Thanks for the pointer, I will look at these patches soon.

Thanks, more testing is always useful - mine was limited to intel/amd machines.
You can try applying them all if you want - they are independent.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies