[openib-general] [PATCH 3/6] [RFC] iser initiator

[Or Gerlitz]

Christoph Hellwig wrote:
>> +/* Constant PDU lengths calculations */
>> +#define ISER_HDR_LEN            sizeof (struct iser_hdr)
>> +#define ISER_PDU_BHS_LENGTH     sizeof (struct iscsi_hdr)
> 
> these two macros are just use in ISER_TOTAL_HEADERS_LEN below,
> just kill them.
> 
>> +#define USE_OFFSET(offset)      (offset)
>> +#define USE_NO_OFFSET           0
>> +#define USE_SIZE(size)          (size)
>> +#define USE_ENTIRE_SIZE         0
> 
> please kill these macros.

both done

------------------------------------------------------------------------
r5468 | ogerlitz | 2006-02-23 15:34:16 +0200 (Thu, 23 Feb 2006) | 5

replaced struct iser_adaptor name to be iser_device, changed
adaptor to device notation everywhere

Signed-off-by: Or Gerlitz <ogerlitz at voltaire.com>

------------------------------------------------------------------------
r5466 | ogerlitz | 2006-02-23 14:38:09 +0200 (Thu, 23 Feb 2006) | 5

eliminated the following defines: ISER_HDR_LEN ISER_PDU_BHS_LENGTH
USE_OFFSET USE_NO_OFFSET USE_SIZE USE_ENTIRE_SIZE

Signed-off-by: Or Gerlitz <ogerlitz at voltaire.com>