[openib-general] Re: [PATCH] mthca - command interface

Michael S. Tsirkin mst at mellanox.co.il
Sun Feb 26 15:55:09 PST 2006


Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH] mthca - command interface
> 
> Thanks, I applied this to svn and queued it for 2.6.17, with a few changes:
> 
>  - Fix initialization of dev->cmd.flags to zero all flags
>  - Fix ioremapping of UAR0 to work on ppc64, etc (where HCA's bus
>    address view doesn't match token that ioremap needs)
>  - Change module parameter name to fw_cmd_doorbell
>  - My usual anal cleanups and style changes
> 
>  - R.

Unfortunately, on some systems we see that command execution time is hurt by
this option. It could be a firmware thing - I think its best to disable
fw_cmd_doorbell by default until we figure it out.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies



More information about the general mailing list