[openib-general] Re: ipoib_multicast_ah.patch

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: ipoib_multicast_ah.patch
> 
> This looks OK, I guess, but...
> 
>     Mst> ipoib_mcast_send tests mcast->ah twice. If this value
>     Mst> is changed between these two points, we leak an skb.
> 
> who else might change the value here?  Answering this would help
> justify the patch and save me from having to write up a changelog entry.

I has a quick look and couldnt see any other place - except when the mcast entry
is freed. Am I missing something?

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies