[openib-general] ipoib_multicast_leak.patch

Michael S. Tsirkin mst at mellanox.co.il
Thu Jan 12 13:56:31 PST 2006


Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: [openib-general] ipoib_multicast_leak.patch
> 
>  > ipoib_multicast_leak.patch
> 
> It seems things can be simplified still further.  I didn't see a
> reason to have both ipoib_mcast_dev_flush() and ipoib_mcast_dev_down(),
> so I rolled everything up into ipoib_mcast_dev_flush().  This passes
> light testing here (and I checked that mcast allocs are balanced by
> mcast frees).  How does this look to you?
> 
>  - R.

Looks sane. But what was the idea behind all the complexity in dev_flush?
Was there some reason for it?


-- 
MST



More information about the general mailing list