[openib-general] Re: [PATCH] CMA and iWARP

[Tom Tucker]

On Thu, 2006-01-19 at 11:30 -0800, Sean Hefty wrote:
> Tom Tucker wrote:
> > 3. Getting the core support in early will give us time to tweak, tune,
> > and test. I think this is a very good thing.
> 
> I'm not disagreeing, but my concern is that if we start applying changes to the 
> trunk to support branches we can end up maintaining a large amount of code that 
> might not even be used.   The maintainers end up needing to track branches to 
> know if they're active, and if a branch ever falls off, then a fair amount of 
> work needs to go back into cleaning up the code.  I don't think that most open 
> source projects go this route.
> 
> - Sean

I think your points are very valid. However, I'd like to propose that a
few things make these particular changes different:

- I (hopefully "We") are certain that iWARP devices _will_ be present,
i.e. the changes won't amount to dead code,

- We are certain that there are developers today that rely on these
changes, 

- Merging in the trunk now helps them get there sooner since they don't
have to track changes to the trunk in a separate branch.

Thanks,

Tom