[openib-general] [PATCH] [MAD] set RMPP version even if RMPP is not active

Sean Hefty mshefty at ichips.intel.com
Tue Jan 24 14:05:41 PST 2006


Sean Hefty wrote:
> The RMPP code actually checks the active flag before checking the version, which
> is wrong, but why this has gone undetected.

On second thought, and checking the spec in more detail...

o13-21.1.3: States that if Active=0, all other fields shall be reserved.

and

o13-21.1.4: Adds that version shall have a value of 1 in all MADs where Active=1.

Given this, I think that the current code _is_ correct.  It's the spec that's
seems broken...

- Sean




More information about the general mailing list