[openib-general] [PATCH] [RFC] group devices by type

Caitlin Bestler caitlinb at broadcom.com
Wed Jan 25 12:37:31 PST 2006


openib-general-bounces at openib.org wrote:
> On Wed, 25 Jan 2006, Sean Hefty wrote:
> 
>> Index: include/rdma/ib_verbs.h
>> ===================================================================
>> --- include/rdma/ib_verbs.h	(revision 5098)
>> +++ include/rdma/ib_verbs.h	(working copy)
>> @@ -57,7 +57,8 @@ union ib_gid {
>>  };
>> 
>>  enum ib_node_type {
>> -	IB_NODE_CA 	= 1,
>> +	IB_NODE_IB = 0x10,		/* mask for all IB node types */
> 
> Is is time to update the prefix to RDMA_ (e.g. RDMA_NODE_IB)?
> 

I would say that symbols that are IB specific are very
low priority for shifting to transport neutral names.

Unless the goal is to eliminate the use of the IB_ prefix
completely I would not bother. It's more important that
the symbols that transport neutral code would use not
have the "IB_" or "ib_" prefixes.




More information about the general mailing list