[openib-general] [PATCH 1/2] perftest: enhancement to rdma_bw to allow use of RDMA CM

Michael S. Tsirkin mst at mellanox.co.il
Wed Jul 5 04:29:13 PDT 2006


Thanks for following up on this, on the surface looks good.
I'm busy at the moment, but a quick question:

Quoting r. Pradipta Kumar Banerjee <bpradip at in.ibm.com>:
> +static void pp_wait_for_done(struct pingpong_context *ctx)
> +{
> +	struct ibv_wc wc;
> +	int ne;
> +
> +	do {
> +		usleep(500);
> +		ne = ibv_poll_cq(ctx->rcq, 1, &wc);
> +	} while (ne == 0);

I wander whether we can get rid of the rcq and an extra send at the
end by simply closing the QP, and ignoring the possible completion with error
for the last round. I think this would be a nice simplification.
What do you think?

-- 
MST




More information about the general mailing list