[openib-general] [PATCH] validate MADs issued from userspace for spec compliance C13-18.1.1

Michael S. Tsirkin mst at mellanox.co.il
Tue Jul 11 12:55:47 PDT 2006


Quoting r. Sean Hefty <sean.hefty at intel.com>:
> Subject: RE: [PATCH] validate MADs issued from userspace for spec compliance C13-18.1.1
> 
> >> I haven't checked this in yet.  I was just about to run some additional tests
> >> before doing this.  My biggest concern is that modifying the TID for SENDs
> >may
> >> cause an issue with some application.
> >
> >How about we check that application has put 0 in high 32 bit, and return
> >an error if it did not?
> 
> This should work if we can determine whether the SEND is a new operation or a
> response to some other request.

Isn't ib_response_mad doing this?

> After further testing, this patch breaks osmtest as a result of modifying the
> TID for a SEND.  

What does the test do?

> I could just ignore SENDs like the existing code did, but I'm
> not convinced that that's the right thing to do.

What does Jack's patch do?

-- 
MST




More information about the general mailing list