[openib-general] Fix some suspicious ppc64 code in dapl

James Lentini jlentini at netapp.com
Mon Jul 17 14:24:08 PDT 2006



On Mon, 17 Jul 2006, Anton Blanchard wrote:

>  
> Hi,
> 
> > Thank you Anton. Could you replying with a signed off by line? I'll 
> > properly attribute this fix to you in the commit log.
> 
> Sorry, I let this one slip. Here it is.
> 
> Anton
> 
> --
> 
> I was reading through the ppc64 specific code in dapl/ and noticed some
> suspicious inline assembly.
> 
> - EIEIO_ON_SMP and ISYNC_ON_SMP are in kernel UP build optimisations, we
>   shouldnt export them to userspace. Replace it with lwsync and isync.
> - The comment says its implemenenting cmpxchg64 but in fact its
>   implementing cmpxchg32. Fix the comment.

Thanks! Committed in revision 8562.




More information about the general mailing list