[openib-general] [PATCH] validate MADs issued from userspace for spec compliance C13-18.1.1

Michael S. Tsirkin mst at mellanox.co.il
Wed Jul 19 07:30:17 PDT 2006


This patch looks good and worked well here for several days.
An earlier version of this patch (by Jack) has also shipped with OFED 1.0.

As was discussed earlier, I suggest queueing this for 2.6.18 - without this
patch, we observe that RMPP transactions are sometimes aborted because of
duplicate packets (which result typically from retries after ACK got lost).

Acked-by: Michael S. Tsirkin <mst at mellanox.co.il>
Acked-by: Jack Morgenstein <jackm at mellanox.co.il>

Quoting r. Sean Hefty <sean.hefty at intel.com>:
Subject: [PATCH] validate MADs issued from userspace for spec compliance C13-18.1.1

Enhance validation of MADs sent by userspace clients for spec
compliance with C13-18.1.1 (duplicate requests / responses).  Also
verify that RMPP MADs are data only, to avoid a userspace app
causing a kernel crash by sending non-data MADs.

Signed-off-by: Sean Hefty <sean.hefty at intel.com>

-- 
MST




More information about the general mailing list