[openib-general] [PATCH][MINOR] OpenSM/osm_sa_informinfo.c: In osm_infr_rcv_process_set_method, if sending error, don't call osm_infr_rcv_process_set_method

Hal Rosenstock halr at voltaire.com
Wed Jul 19 13:33:49 PDT 2006


OpenSM/osm_sa_informinfo.c: In osm_infr_rcv_process_set_method, if
sending error, don't call osm_infr_rcv_process_set_method

Also, fix typo in osm_log message

Signed-off-by: Hal Rosenstock <halr at voltaire.com>

Index: opensm/osm_sa_informinfo.c
===================================================================
--- opensm/osm_sa_informinfo.c	(revision 8600)
+++ opensm/osm_sa_informinfo.c	(working copy)
@@ -501,7 +501,7 @@ osm_infr_rcv_process_set_method(
       /* No Such Item - So Error */
       osm_log( p_rcv->p_log, OSM_LOG_ERROR,
                "osm_infr_rcv_process_set_method: ERR 4307: "
-               "Failed to UnSubscribe to non exiting inform object\n");
+               "Failed to UnSubscribe to non existing inform object\n");
 
       /* o13-13.1.1:  we need to set the subscribe bit to 0 */
       p_recvd_inform_info->subscribe = 0;
@@ -546,9 +546,11 @@ osm_infr_rcv_process(
              "Unsupported Method (%s)\n",
              ib_get_sa_method_str( p_sa_mad->method ) );
     osm_sa_send_error( p_rcv->p_resp, p_madw, IB_MAD_STATUS_UNSUP_METHOD_ATTR );
+    goto Exit;
   }
 
   osm_infr_rcv_process_set_method( p_rcv, p_madw );
 
+ Exit:
   OSM_LOG_EXIT( p_rcv->p_log );
 }







More information about the general mailing list