[openib-general] [PATCH] osm: bug on SM generated Notice Reports

Hal Rosenstock halr at voltaire.com
Mon Jul 24 02:44:54 PDT 2006


Hi Eitan,

On Sun, 2006-07-23 at 05:01, Eitan Zahavi wrote:
> Hi Hal
> 
> When formating an SM generated report the ProducerType was using CL_NTOH32 
> which can not be used to format a 24bit network order number.
> 
> The propose fix also avoids the duplication of conversion to and from network 
> order introduced by the previous use of ib_notice_set_prod_type that requires 
> a network ordered argument.
> 
> The fix introduces ib_notice_set_prod_type_ho which is similar but requires
> host order value.
> For completeness I also introduced the ib_notice_set_vend_id_ho.

Thanks. Applied in r8640.

Are the network order routines ( ib_notice_set_prod_type and
ib_notice_set_vend_id) still needed or should they be eliminated ?

-- Hal

> Eitan
> 
> Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il>






More information about the general mailing list