[openib-general] 3 patches in mst-for-2.6.18

Michael S. Tsirkin mst at mellanox.co.il
Mon Jul 24 11:10:06 PDT 2006


Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: 3 patches in mst-for-2.6.18
> 
>  > Roland, I have put the following patches in my mst-for-2.6.18 tree:
> 
> OK, I have all three.
> 
> I updated this:
> 
>  >    [PATCH] IB/mad: validate MADs for spec compliance C13-18.1.1
> 
> with the following, which uninlines ib_response_mad() for the
> following size savings:
> 
>    text    data     bss     dec     hex filename
> 2017675  434628  175844 2628147  281a33 ../vmlinux.orig
> 2017539  434652  175844 2628035  2819c3 ../vmlinux.noinline

Looks fine.

One point to take into account, in my experience, is that to be fair with size
savings checks, you should build with -Os.

Otherwise compiler seems to behave in a wildly unpredictable way with respect to
code size - sometimes removing code results in size increases as compiler
decides to e.g.  unroll some loops.

-- 
MST




More information about the general mailing list