[openib-general] [PATCH 1/6] libibverbs include files changes.

Steve Wise swise at opengridcomputing.com
Fri Jul 28 12:35:59 PDT 2006


On Fri, 2006-07-28 at 12:27 -0700, Roland Dreier wrote:
>  > Why not just do:
>  > 
>  > #define rdma_structure_name ibv_structure_name
>  > 
>  > Then we simply remove the #define and replace ibv_structure_name with 
>  > rdma_structure_name when ready.  This better shows the changes, prevents 
>  > duplicating every structure, and should avoid any compile warnings.
> 
> I agree, except let's make rdma_structure_name the real name, and do
> the define the opposite way.  That way it's easier to remove the
> compatibility stuff later.
> 
>  - R.

Uh, won't that break binary compatibility?  Or is that not a
requirement?  IE: If you make the ibv_* names #defines, then all apps
will have to recompile to use the new lib.  If you leave them as the
real names, then apps can still link to the new lib and run ok...i
think...








More information about the general mailing list