[openib-general] Fix some suspicious ppc64 code in dapl

[Tziporet Koren]

Hi James,
Is it important to take this patch to the OFED release?

Thanks
Tziporet

-----Original Message-----
From: openib-general-bounces at openib.org
[mailto:openib-general-bounces at openib.org] On Behalf Of James Lentini
Sent: Monday, June 05, 2006 4:39 PM
To: Anton Blanchard
Cc: openib-general at openib.org
Subject: Re: [openib-general] Fix some suspicious ppc64 code in dapl


> Index: dapl/udapl/linux/dapl_osd.h
> ===================================================================
> --- dapl/udapl/linux/dapl_osd.h	(revision 7621)
> +++ dapl/udapl/linux/dapl_osd.h	(working copy)
> @@ -238,14 +238,13 @@
>  #endif /* __ia64__ */
>  #elif defined(__PPC64__)
>          __asm__ __volatile__ (
> -        EIEIO_ON_SMP
> -"1:     lwarx   %0,0,%2         # __cmpxchg_u64\n\
> -        cmpd    0,%0,%3\n\
> +"       lwsync\n\
> +1:      lwarx   %0,0,%2         # __cmpxchg_u32\n\
> +        cmpw    0,%0,%3\n\
>          bne-    2f\n\
>          stwcx.  %4,0,%2\n\
> -        bne-    1b"
> -        ISYNC_ON_SMP
> -        "\n\
> +        bne-    1b\n\
> +        isync\n\
>  2:"
>          : "=&r" (current_value), "=m" (*v)
>          : "r" (v), "r" (match_value), "r" (new_value), "m" (*v)

Thank you Anton. Could you replying with a signed off by line? I'll 
properly attribute this fix to you in the commit log.
_______________________________________________
openib-general mailing list
openib-general at openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit
http://openib.org/mailman/listinfo/openib-general