[openib-general] [PATCH] osm: fix num of blocks of GUIDInfo GetTable query

[Hal Rosenstock]

On Sun, 2006-06-11 at 20:40, Greg Lindahl wrote:
> So this is a _critical_ bugfix ?

Depends on one's definition.

Anyhow, it's been applied to 1.0.

-- Hal

> 
> > Auuuch it is there! 
> > My mistake. Sp please apply the patch to the OFED 1.0 branch too.
> > BTW: Is the osmtest -f a excersizes this query on the OFED 1.0 ?
> > 
> > > Huh ? What's
> > >
> > https://openfabrics.org/svn/gen2/branches/1.0/src/userspace/management/o
> > sm/opens
> > > m/osm_sa_guidinfo_record.c
> > > 
> > > -- Hal
> > > 
> > > >
> > > > Eitan Zahavi
> > > > Senior Engineering Director, Software Architect
> > > > Mellanox Technologies LTD
> > > > Tel:+972-4-9097208
> > > > Fax:+972-4-9593245
> > > > P.O. Box 586 Yokneam 20692 ISRAEL
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Hal Rosenstock [mailto:halr at voltaire.com]
> > > > > Sent: Sunday, June 11, 2006 12:22 AM
> > > > > To: Eitan Zahavi
> > > > > Cc: OPENIB
> > > > > Subject: Re: [PATCH] osm: fix num of blocks of GUIDInfo GetTable
> > query
> > > > >
> > > > > Eitan,
> > > > >
> > > > > On Thu, 2006-06-08 at 07:24, Eitan Zahavi wrote:
> > > > > > Hi Hal
> > > > > >
> > > > > > I'm working on passing osmtest check. Found a bug in the new
> > > > > > GUIDInfoRecord query: If you had a physical port with zero
> > guid_cap
> > > > > > the code would loop on blocks 0..255 instead of trying the next
> > > > port.
> > > > > >
> > > > > > I am still looking for why we might have a guid_cap == 0 on some
> > > > > > ports.
> > > > > >
> > > > > > This patch resolves this new problem. osmtest passes on some
> > > > arbitrary
> > > > > > networks.
> > > > > >
> > > > > > Eitan
> > > > > >
> > > > > > Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il>
> > > > >
> > > > > Thanks. Applied to trunk only.
> > > > >
> > > > > Let me know if it also should be applied to 1.0.
> > > > >
> > > > > -- Hal
> > 
> > _______________________________________________
> > openib-general mailing list
> > openib-general at openib.org
> > http://openib.org/mailman/listinfo/openib-general
> > 
> > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> 
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>