[openib-general] [PATCH] mthca: memfree completion with error workaround

Michael S. Tsirkin mst at mellanox.co.il
Mon Jun 12 21:47:40 PDT 2006


Quoting r. Roland Dreier <rdreier at cisco.com>:
> But it bloats the function and adds to i-cache footprint.  I'm sure it
> benchmarks fine but it adds to general cache usage that pushes useful
> code out of cache.

Hmm. Would you be more comfortable with just

+               if (unlikely(wqe_index >= wq->max))
+               	wqe_index = wq->max - 1;

The other case is there just in case, to catch firmware errors.

-- 
MST




More information about the general mailing list