[openib-general] [PATCHv2] osm: pkey manager fail to clear unused block

Hal Rosenstock halr at voltaire.com
Mon Jun 26 03:43:48 PDT 2006


Hi Eitan,

On Mon, 2006-06-26 at 03:00, Eitan Zahavi wrote:
> Hi Hal
> 
> Had some second thought (slept on it) about this patch. 
> It has a problem as it would continuously set a block if it is all empty (since the new
> block does not exist)
> 
> The new patch fixes it by catching the case of null new_block and
> still comparing to the old block. 
> 
> I also hope I did better job on the indentation (at least I used untabify).
> 
> > Done some basic test with the simulator. Seems that the manager miss all
> > blocks needed to be cleared (as they used to have some pkeys that are not part of 
> > the policy). The following trivial patch fixes the issue. The bug sneaked in 
> > through the last few patched.
> 
> Eitan
> 
> Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il>

Thanks. Applied.

-- Hal





More information about the general mailing list