[openib-general] RE: [PATCH] osm: Adding revision empty file

[Hal Rosenstock]

On Wed, 2006-03-01 at 10:43, Sasha Khapyorsky wrote:
> On 16:50 Wed 01 Mar     , Ofer Gigi wrote:
> >
> > To reproduce:
> > 
> > 	cd src/userspace/management/osm
> > 	./autogen.sh
> > 	./configure --disable-libcheck
> > 	make dist
> 
> Hal, Ofer, do we need distributible osm_svn_revision.h? If not we may just 
> remove it from dist and dep lists. If yes then probably we may move
> osm_svn_revision.h generation to include/Makefile.am.
> 
> To add autogenerated file under source control is not good idea.

That was what caused the problem in the first place.

-- Hal

> 
> Sasha.
> 
> > make[1]: Entering directory
> > `/tmp/openib_branch1.0/src/userspace/management/osm/osmtest'
> >  cd . && /bin/sh
> > /tmp/openib_branch1.0/src/userspace/management/osm/osmtest/config/missin
> > g --run automake-1.9 --foreign  Makefile  cd . && /bin/sh
> > ./config.status Makefile depfiles
> > config.status: creating Makefile
> > config.status: executing depfiles commands
> > make[1]: Leaving directory
> > `/tmp/openib_branch1.0/src/userspace/management/osm/osmtest'
> > make[1]: Entering directory
> > `/tmp/openib_branch1.0/src/userspace/management/osm/osmtest'
> > make[1]: *** No rule to make target `opensm/osm_svn_revision.h', needed
> > by `distdir'.  Stop.
> > make[1]: Leaving directory
> > `/tmp/openib_branch1.0/src/userspace/management/osm/osmtest'
> > make: *** [distdir] Error 1
> > 
> > Regards,
> > Vladimir
> >