[openib-general] Re: [PATCH 1 of 2] static rate encoding change (kernel)

[Michael S. Tsirkin]

Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [PATCH 1 of 2] static rate encoding change (kernel)
> 
> Jack Morgenstein wrote:
> >For static rate encoding, use encoding rate field from PathRecord,
> >with addition of value 0, for backwards compatibility with
> >current usage.
> >
> >Push translation of static rate to IPD value down to provider layer.
> 
> Patch looks fine to me, with a couple of nits below.
> 
> >+enum ib_max_static_rate {
> >+	IB_MAX_STATIC_RATE_PORT_CURRENT_MAX = 0,
> 
> maybe just name this IB_MAX_STATIC_RATE

good idea.

> >+static inline int ib_static_rate_enum_to_int(enum ib_max_static_rate rate)
> 
> Can we find a shorter/more descriptive name for this routine?

since its only used in ipoib debug fs, we can just move it out of a header.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies