[openib-general] [PATCH 01/17] ehca: integration in Linux kernel build system

[Roland Dreier]

 > --- linux-2.6.16-rc4-orig/drivers/infiniband/hw/ehca/Makefile	1970-01-01 01:00:00.000000000 +0100
 > +++ linux-2.6.16-rc4/drivers/infiniband/hw/ehca/Makefile	2006-02-28 10:48:43.000000000 +0100
 > @@ -0,0 +1,54 @@
 > +#  IBM eServer eHCA Infiniband device driver for Linux on POWER
 > +#
 > +#  makefile for ehca kernel driver
 > +#
 > +#  Authors: Heiko J Schick <schickhj at de.ibm.com>
 > +#           Christoph Raisch <raisch at de.ibm.com>
 > +#
 > +#  Copyright (c) 2005 IBM Corporation
 > +#
 > +#  All rights reserved.
 > +#
 > +#  This source code is distributed under a dual license of GPL v2.0 and OpenIB BSD.
 > +#
 > +# OpenIB BSD License

...and so on...

The Makefile should not have so much licensing text.  At most 1 or 2
lines is acceptable, and better still would be to match the vast
majority of kernel Makefiles: no copyright notice at all

 > +ifndef GEN2_PATH_KERNEL
 > +GEN2_PATH_KERNEL = drivers
 > +endif

Can this chunk be killed?  What is it for?

 > +obj-$(CONFIG_INFINIBAND_EHCA) += hcad_mod.o
 > +
 > +hcad_mod-objs = ehca_main.o ehca_hca.o ipz_pt_fn.o ehca_classes.o ehca_av.o \
 > +	ehca_pd.o ehca_mrmw.o ehca_cq.o ehca_sqp.o ehca_qp.o \
 > +	ehca_eq.o ehca_irq.o hcp_phyp.o ehca_mcast.o ehca_reqs.o \
 > +	ehca_uverbs.o hcp_if.o
 > +
 > +CFLAGS +=-DP_SERIES -DEHCA_USE_HCALL -DEHCA_USE_HCALL_KERNEL \
 > +	-I$(src)  \
 > +	-I$(GEN2_PATH_KERNEL)/infiniband/include \
 > +	-I$(GEN2_PATH_KERNEL)/infiniband/core

The include paths look superfluous here.  (the infiniband/include one
is OK for svn, but we'll need to strip that when it goes into the
kernel).  What are you including from /core?  And is the $(src) still
needed now that you use #include "foo" instead of #include <foo> for
your local includes?

 - R.