[openib-general] [PATCH] CM: check cm_id state before handling a REP

Sean Hefty mshefty at ichips.intel.com
Thu Mar 2 12:00:27 PST 2006


Roland Dreier wrote:
> This is broken -- you've used the same flags variable twice,
> overwriting it the second time.
> 
> If you have nested spinlocks, then you only need to disable
> interrupts.  In other words, the lock of cm.lock can become a straight
> spin_lock(), and unlock just spin_unlock().

Thanks for catching this.  My copy/paste of the code is obviously flawed.

- Sean



More information about the general mailing list