[openib-general] [PATCH 05/17] ehca: InfiniBand query and multicast functionality

Fri Mar 3 06:35:59 PST 2006

Hello Hal!
Yes, will fix that. Good catch. Thanks!

Mit freundlichen Gruessen/Kind Regards
Hoang-Nam Nguyen

             Hal Rosenstock                                                
             <halr at voltaire.co                                             
             m>                                                         To 
                                       schihei at de.ltcfwd.linux.ibm.com     
             03.03.2006 13:56                                           cc 
                                       openib-general at openib.org,          
                                       Christoph Raisch/Germany/IBM at IBMDE, 
                                       Hoang-Nam Nguyen/Germany/IBM at IBMDE  
                                                                   Subject 
                                       Re: [openib-general] [PATCH 05/17]  
                                       ehca: InfiniBand query and          
                                       multicast functionality             

On Thu, 2006-03-02 at 03:37, Heiko J Schick wrote:

> --- linux-2.6.16-rc4-orig/drivers/infiniband/hw/ehca/ehca_mcast.c
 1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.16-rc4/drivers/infiniband/hw/ehca/ehca_mcast.c
2006-02-28 12:41:24.000000000 +0100

> +#define MAX_MC_LID 0xFFFE
> +#define MIN_MC_LID 0xC000         /* Multicast limits */
> +#define EHCA_VALID_MULTICAST_GID(gid)  ((gid)[0] == 0xFF)
> +#define EHCA_VALID_MULTICAST_LID(lid)  (((lid) >= MIN_MC_LID) && ((lid)
<= MIN_MC_LID))

Should this be:
#define EHCA_VALID_MULTICAST_LID(lid)  (((lid) >= MIN_MC_LID) && ((lid) <=
MAX_MC_LID))

-- Hal