[openib-general] [PATCH] mthca - read byte count & read request size

Roland Dreier rdreier at cisco.com
Tue Mar 7 08:37:17 PST 2006


    Eli> Using an enum confines the set of valid values the user can
    Eli> specify to the range 0-3 and it is easier to filter out
    Eli> invalid values. If I used raw values for the parameters then
    Eli> questions like how do I interpret a value of 1000 would rise:
    Eli> As invalid value so the parameter is ignored?  Or maybe I
    Eli> would configure rbc to 512? or 1024?

I think it's really unfriendly that a user has to read the source to
figure out how to set these values.  I'm not sure what the best
interface is though -- maybe print a warning and ignore invalid
values?

 - R.



More information about the general mailing list