[openib-general] [PATCH] opensm: fixes in signal handling

Hal Rosenstock halr at voltaire.com
Wed Mar 8 04:28:29 PST 2006


On Tue, 2006-03-07 at 12:57, Sasha Khapyorsky wrote:
> On 21:41 Wed 01 Mar     , Sasha Khapyorsky wrote:
> > On 01:33 Wed 22 Feb     , Sasha Khapyorsky wrote:
> > > 
> > > This fixes broken signal handling. In this patch:
> > 
> > There is updated patch. Additions are:
> > 
> >  - SIGINT handling is re-enabled
> >  - only handled signals are masked
> >  - update against recent SVN
> 
> There is updated patch. Changes (due to comments and tests) are:
> 
>  - fix against linuxthreads - sigprocmask() is replaced by
>    pthread_sigmask()
>  - fix for case without resweeper thread (when -s 0 is used)
>  - removing unused include files
> 
> Sasha.
> 
> 
> Signaling patch.
> 
> This fixes broken signal handling. In the patch:
> 
>  - signal handling stuff is moved to main.c
>  - cl_sig_* is replaced by more powerfull posix (I hope it should not
>    be bad for win because this is under !__WIN__ anyway)
>  - SIGINT is handled again
>  - signal handler does not call resweeper or wakeup directly, but only
>    update new osm_hup_flag (or osm_exit_flag on SIGINT or SIGTERM)
>  - handled signals delivery are masked for all threads expept first one,
>    so only expected thread will be interrupted (from sleep() or poll())
>  - resweep thread will be wakeuped from main.c thread instead direct
>  - poll was added to osm_console - this provides timeout ability and
>    workarouds getline()'s signal interruption problem.
> 
> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

Thanks! Applied (in both trunk and 1.0 branch).

-- Hal





More information about the general mailing list