[openib-general] Re: [PATCH 0/7] AMSO1100 RNIC Driver

Roland Dreier rdreier at cisco.com
Thu Mar 16 14:50:42 PST 2006


 > - BE issue resolved by using __raw_write[lw](cpu_to_be[32|16]...

I think maybe you sent out the wrong patchset (or maybe I screwed up
my mail folder and have an old patchset).  But I see stuff like:

 > +#define C2_SET_CUR_RX(c2dev, cur_rx) \
 > +	writel(cpu_to_be32(cur_rx), c2dev->mmio_txp_ring + 4092)

which is going to be bad on a big-endian arch.

BTW, I'm setting up my PPC 4xx board again soon, so I'll be able to
try this driver on a big-endian, non-cache-coherent DMA system.

 - R.



More information about the general mailing list