[openib-general] Re: [PATCH] mthca - query qp

[Eli Cohen]

On Thu, 2006-03-16 at 14:38 -0800, Roland Dreier wrote:
> I need to think about how to handle the other attributes.  Probably
> anything that just copies values from the struct ib_qp passed in to
> the function should at least be in the generic ib_query_qp function,
> since there's no good reason for every low-level driver to duplicate it.
> 
Probably this is how it should be done

> However I'm wondering whether we even have the right interface for
> query QP at all.  The only thing that the consumer couldn't have saved
> off for themselves is the QP state, so maybe the right interface is
> just an ib_query_qp_state() function that gives back the QP's current state.
> 
I think we should pass to the consumer all the info in a centralized way
through a standard query_qp verb.