[openib-general] Re: IPoIB oops when removing ib_ipoib module

[Hal Rosenstock]

On Mon, 2006-03-20 at 16:12, Roland Dreier wrote:
>     Hal> With the latest OpenIB svn, I got the following oops when
>     Hal> attempting to remove the ib_ipoib module on x86 with 2.6.15.
> 
> Hmm, I can't understand what's going on here, nor can I reproduce it.
> Can you try to get it to happen with the patch below applied?

Sure but I'm not sure I can reproduce it.

-- Hal

> 
> Thanks,
>   Roland
> 
> Index: infiniband/ulp/ipoib/ipoib_main.c
> ===================================================================
> --- infiniband/ulp/ipoib/ipoib_main.c	(revision 5911)
> +++ infiniband/ulp/ipoib/ipoib_main.c	(working copy)
> @@ -814,6 +814,8 @@ void ipoib_neigh_free(struct ipoib_neigh
>  		if (nn->neighbour->ops == neigh->neighbour->ops)
>  			goto found;
>  
> +	BUG_ON(!neigh->neighbour);
> +	BUG_ON(!neigh->neighbour->ops);
>  	neigh->neighbour->ops->destructor = NULL;
>  found:
>  	spin_unlock(&ipoib_all_neigh_list_lock);