> +static void ipoib_pkey_dev_check_presence(struct net_device *dev); Please just move the function before you use it to avoid this forward declaration. > + ipoib_pkey_dev_check_presence(dev); Whitespace damage here... (and possibly elsewhere) - R.