[openib-general] Re: RFC: e2e credits

[James Lentini]

On Thu, 23 Mar 2006, Michael S. Tsirkin wrote:

mst> Guys, please review the verbs.h extension below - I'll be 
mst> submitting a patch including CM update and mthca implementation 
mst> next week. Anyone has a problem with this?
mst> 
mst> Index: openib/drivers/infiniband/include/rdma/ib_user_verbs.h
mst> ===================================================================
mst> --- openib.orig/drivers/infiniband/include/rdma/ib_user_verbs.h	2006-03-02 21:41:01.000000000 +0200
mst> +++ openib/drivers/infiniband/include/rdma/ib_user_verbs.h	2006-03-23 00:50:48.000000000 +0200
mst> @@ -378,7 +378,8 @@ struct ib_uverbs_qp_attr {
mst>  	__u8	rnr_retry;
mst>  	__u8	alt_port_num;
mst>  	__u8	alt_timeout;
mst> -	__u8	reserved[5];
mst> +	__u8    flow_control;
mst> +	__u8	reserved[4];
mst>  };
mst>  
mst>  struct ib_uverbs_create_qp {
mst> Index: openib/drivers/infiniband/include/rdma/ib_verbs.h
mst> ===================================================================
mst> --- openib.orig/drivers/infiniband/include/rdma/ib_verbs.h	2006-03-02 21:41:01.000000000 +0200
mst> +++ openib/drivers/infiniband/include/rdma/ib_verbs.h	2006-03-23 00:50:28.000000000 +0200
mst> @@ -573,6 +573,7 @@ struct ib_qp_attr {
mst>  	u8			rnr_retry;
mst>  	u8			alt_port_num;
mst>  	u8			alt_timeout;
mst> +	u8			flow_control;
mst>  };
mst>  
mst>  enum ib_wr_opcode {

Will there be a default value? If so, what will it be?

My vote would be for off.

Does all hardware support the ability to turn this on/off?