[openib-general] Re: [PATCH 5 of 13] ipath - use proper address translation routine

Roland Dreier rdreier at cisco.com
Mon May 1 11:50:36 PDT 2006


    Bryan> Move away from an obsolete, unportable routine for
    Bryan> translating physical addresses.

This change:

 > -		isge->vaddr = bus_to_virt(sge->addr);
 > +		isge->vaddr = phys_to_virt(sge->addr);

is really wrong.  bus_to_virt() is really what you want, because in
this case the address is a bus address that came from dma_map_xxx().
You're still going to be hosed on systems with IOMMUs for example.

 - R.



More information about the general mailing list