[openib-general] Re: [PATCH 00/12] SRP: Changing ibsrpdm

[Ishai Rabinovitz]

On Mon, May 01, 2006 at 10:53:36AM -0700, Roland Dreier wrote:
>     Ishai> Hi, I'm going to send 12 patches. 6 patches for the kernel,
>     Ishai> and 6 for the userspace ibsrpdm.  The kernel patches avoid
>     Ishai> adding the same target twice, allow the removal of a
>     Ishai> target, and add a query about the connected targets.
> 
> In the future can you use a different descriptive title for each patch?

OK

> 
> Also (although I haven't reviewed the actual code yet) this mostly
> makes sense, but I'm not sure we want to disallow connecting to the
> same target twice.  Userspace may want to implement a policy of one
> conncetion per target, but having multiple connections to the same
> target for multipathing/failover seems like something the kernel
> should allow.  What was your reason for forbidding this?
> 
>  - R.

As I understand it, the path in multipathing is going to be part of the 
attributes of the connection to the target. So there will be no problem
to add the same target twice, if it has a different path leading to it.
-- 
Ishai Rabinovitz