[openib-general] Re: [PATCH 09/12] SRP: Changing ibsrpdm

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH 09/12] SRP: Changing ibsrpdm
> 
>     Ishai> alloca man page on my system says: The alloca() function is
>     Ishai> machine and compiler dependent.  On many systems its
>     Ishai> implementation is buggy. Its use is discouraged.  Lets not
>     Ishai> use it.
> 
> The man page is talking about non-Linux systems I think.  I don't know
> of any problems with any modern Linux libc so I think it's better to
> have something automatically leak proof.

Fine, but note that what Ishai did is also leak-proof.
Since the size is constant SIZE_OF_QUERY_RESPONSE, what's the reason for playing
tricks with alloca?

-- 
MST